Don't downsample Pooled CPS #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Tests not running due to expiry of GitHub PAT |
Collaborator
Author
|
Tests now failing due to some sort of county FIPS error; unclear what's going on |
Collaborator
Author
|
Attempting to fix in most recent push |
nikhilwoodruff
requested changes
Apr 14, 2025
Contributor
nikhilwoodruff
left a comment
nikhilwoodruff
left a comment
There was a problem hiding this comment.
Just a few minor fixes, then LGTM
nikhilwoodruff
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207.
This PR introduces a very naïve means of preventing downsampling when constructing the Pooled 3-Year CPS dataset, which we use by default for states due to states' limited number of observations in any given single year CPS set. This PR creates three new datasets - essentially the old un-downsampled 2021, '22, and '23 CPS - then uses those to construct the Pooled 3-Year while maintaining the default downsampled versions of these, as well.
This code should be improved separately, and if this code is still here, unchanged, on July 1, 2025, someone should open a ticket.